search

zth / rescript-relay

Use Relay with ReScript.
https://rescript-relay-documentation.vercel.app/docs/getting-started
339 stars 53 forks source link

Use ReScript 10 #397

Closed MoOx closed 2 years ago

MoOx commented 2 years ago

Closes #396

zth commented 2 years ago

Just wondering, does this mean 10+ is required? If so, can we make it so that 9 is also allowed?

MoOx commented 2 years ago

I think we could use ">=9". But in case you start to use v10 feature, it won't work and you might not be aware of it. Anyway people can always use npm overrides in case they think it's "ok for them to have v9" ?

zth commented 2 years ago

I think allowing 9 now as well to start would be ideal. I have a few features in the pipe that will require v10, and at that point I can bump the minimum to v10. Would that be ok for you and your use case too?

MoOx commented 2 years ago

Should be ok, I used 10 for devDep, but peerDep to >=9.1.2

zth commented 2 years ago

Thank you @MoOx ! Would you also add an entry to the changelog?

MoOx commented 2 years ago

@zth done !

zth commented 2 years ago

🙏 thank you @MoOx !