zthxxx / react-dev-inspector

jump to local IDE code directly from browser React component by just a simple click
https://react-dev-inspector.zthxxx.me
MIT License
1.15k stars 68 forks source link

feat: inspect element immediately at mouse point while press hotkey #108

Closed zthxxx closed 2 years ago

zthxxx commented 2 years ago

for resolve #105 #106

cc: @murugaratham

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zthxxx/react-dev-inspector/osNtHqFZ1LJUcB9rvrWH5JwgEGYa
✅ Preview: https://react-dev-inspector-git-feat-interaction-at-startup-zthxxx.vercel.app

zthxxx commented 2 years ago

@murugaratham I'll merge it if you confirm it looks good

murugaratham commented 2 years ago

Just a small thing, but it seems to only happen at src/layouts/index.tsx, but for the considerations of trying not to alter Overlay.js. I think it looks good to me

Screenshot 2021-11-02 at 5 05 52 PM

zthxxx commented 2 years ago

Just a small thing, but it seems to only happen at src/layouts/index.tsx, but for the considerations of trying not to alter Overlay.js. I think it looks good to me

cause by dom order

image

murugaratham commented 2 years ago

I think it's a very minor issue, maybe a .nvmrc would do more good 😀

murugaratham commented 2 years ago

Just a small thing, but it seems to only happen at src/layouts/index.tsx, but for the considerations of trying not to alter Overlay.js. I think it looks good to me

cause by dom order

image

I just noticed that it can be seen "reproduced" at the start of the gif https://react-dev-inspector.zthxxx.me/images/inspect.gif

zthxxx commented 2 years ago

@murugaratham updated

image

zthxxx commented 2 years ago

release in react-dev-inspector@1.7.1

zthxxx commented 2 years ago

I think it's a very minor issue, maybe a .nvmrc would do more good 😀

for development, this project works with node >= v12 and npm >= v7, but in node v12/v14 now default version of npm is still v6