[#36] Inspect code style

sia-txt commented 4 years ago

Fixes #36

Continuous inspecting is needed.

coveralls commented 4 years ago

Coverage remained the same at 84.041% when pulling 663cc391e640df00a0b29213d0a6836019274f55 on Amazansia:36_Inspect_code_style into 4a8bbb09f6265b1df0713c2be83c7a07583cdc9c on ztkmkoo:develop.

Alencion commented 4 years ago

Hi, I found the unused import statements in dss-server/test/DssRestServerTest.java.

Could you remove it?

sia-txt commented 4 years ago

Hi, I found the unused import statements in dss-server/test/DssRestServerTest.java.

Could you remove it?

Hi! Thank you for reviewing. I think I missed checking all the import statements...I'll check and revise them.

sia-txt commented 4 years ago

I learned a lot after 5 commits...and typing "git commit -m [#36] Inspect code style" 5 times.

There are some changes in final commit: to reviewers (Thanks in advance!)

Plz check dss-server.test.DssRestServerTest.java. According to code style rules, every static thing has to be placed at first. But here's a thing, that static things are too many. So I think I did it correctly, but still confusing...
I removed unused import statements at DssRestServerTest.java. And there was no such unused import statements in other files.

I edited pom.xml in dss-server, to catch right version of external library. like...

<properties>
    <!-- Dependencies version -->
    **<dss-core.version>0.4.4</dss-core.version>**
    <akka.version>2.6.3</akka.version>
</properties>

ztkmkoo commented 4 years ago

@Amazansia Hi, I'm so sorry for changing the code.(I push some commits to your branch) from e4aa8285fb20da31f5fdcb71717ac67e22117266 to 0f8a569fe8e8dfe0e0eb73a07d4a2b43240ab4cf. Please pull your branch before you pushing commit.

From now on i will give you the suggestion bout the code style..

sia-txt commented 4 years ago

God bless this commit and let it be closed, Amen. (I'm a atheist)

ztkmkoo / dss

[#36] Inspect code style #108