ztlawton / workshoplocator

0 stars 0 forks source link

Build #1

Closed JamesBremner closed 1 year ago

JamesBremner commented 1 year ago

Steps to build:

JamesBremner commented 1 year ago

The only reason to commit non working code is so that someone else can debug it. Even then you must commit everythin in one commit. It is a nightmare to understand what you are doing if all we can see is tiny bits and pieces of code.

ztlawton commented 1 year ago

When you make changes to a file I am also working on, what is the proper way to update my copy with your changes?

JamesBremner commented 1 year ago

The problem is that there is a missing break statement after the radiator branch. The result is that the execution falls through to the default branch and throws the exception.

image

JamesBremner commented 1 year ago

You also need to change this line

https://github.com/ztlawton/workshoplocator/blob/e6d51eefe6b97cdd1897fd3790bda18ab5737281/src/cWorkshop.cpp#L124

it should be

std::vector<float> PBPtype(6);
JamesBremner commented 1 year ago

https://github.com/JamesBremner/workshoplocator/commit/9d8912beb80146c38e822233c1f7f659ca838744

JamesBremner commented 1 year ago

I think this can be closed