search

ztratar / followr

A no-frills chrome extension to gain followers on twitter through tasteful automation.
ztratar.github.io/followr
146 stars 30 forks source link

v1 gathers hundreds of tweets to favorite #3

Closed suchow closed 10 years ago

suchow commented 10 years ago

I recently upgraded to v1. The first time I ran it (after clicking save) it gathered 896 tweets to favorite and started chugging along at about one per second. Since it gave no hint of stopping, I closed the window manually at ~30 and, in the meantime, disabled the extension.

suchow commented 10 years ago

e.g., see: image

This is on Chrome 33.0.1750.152. I've listed around 30 terms, many with two or three words.

ztratar commented 10 years ago

Firstly, thank you for the issue!

Has this happened again? Can you reproduce? What search terms are you use and when you click the tab, what does the page itself look like?

suchow commented 10 years ago

I'm not sure. I uninstalled the extension and then reinstalled the latest version. Now it hangs on "FINDING NEW TWEETS..." with the words "Followr – Finding Avatar" in the title.

ztratar commented 10 years ago

Are you logged into twitter?

-- Zach Tratar ztratar@gmail.com - 630.854.8826

zachtratar.com

On Mon, Mar 31, 2014 at 3:46 PM, Jordan Suchow notifications@github.comwrote:

I'm not sure. I uninstalled the extension and then reinstalled the latest version. Now it hangs on "FINDING NEW TWEETS..." with the words "Followr - Finding Avatar" in the title.

Reply to this email directly or view it on GitHubhttps://github.com/ztratar/followr/issues/3#issuecomment-39151820 .

suchow commented 10 years ago

Yes.

ztratar commented 10 years ago

How long is it hanging there for? This sounds strange? Can you send me a screenshot of your twitter.com? When the tabs open, can you 'inspect element' and see if the console has any errors?

-- Zach Tratar ztratar@gmail.com - 630.854.8826

zachtratar.com

On Mon, Mar 31, 2014 at 3:47 PM, Jordan Suchow notifications@github.comwrote:

Yes.

Reply to this email directly or view it on GitHubhttps://github.com/ztratar/followr/issues/3#issuecomment-39151920 .

suchow commented 10 years ago

It seems to hang there indefinitely (well, it's been 10 minutes). It happens every time. I tried clearing Chrome's browsing data, closing Chroming, reopening it, and logging into Twitter. I see the following:

[redacted]

And the console says:

screen shot 2014-03-31 at 7 06 17 pm

suchow commented 10 years ago

Okay, I have a little more data on this issue. If I look at all the GET requests, I see that all the searches are being made, three per term. However, underscore and jquery fail:

[redacted]

ztratar commented 10 years ago

Those are simply source map files, so that shouldn't result in any problems. Actually, if the title changes at all or the queries are being made, then jQuery must be loaded.

What's the warning I'm seeing in the top right? Click console to view it. How many search queries do you have and what are they? I might be able to repro then.

Also, when you open the followr popup, what does it look like? Does your user information show up?

-- Zach Tratar ztratar@gmail.com - 630.854.8826

zachtratar.com

On Mon, Mar 31, 2014 at 4:19 PM, Jordan Suchow notifications@github.comwrote:

Okay, I have a little more data on this issue. If I look at all the GET requests, I see that all the searches are being made, three per term. However, underscore and jquery fail:

[image: screen shot 2014-03-31 at 7 12 40 pm]https://cloud.githubusercontent.com/assets/613981/2574066/0a9aabc8-b92a-11e3-8bdc-3904ce03f803.jpg [image: screen shot 2014-03-31 at 7 12 55 pm]https://cloud.githubusercontent.com/assets/613981/2574067/0a9b4a88-b92a-11e3-87c5-6582c9fb461e.jpg

Reply to this email directly or view it on GitHubhttps://github.com/ztratar/followr/issues/3#issuecomment-39154198 .

ztratar commented 10 years ago

Woah! Holy crap that's a lot of topics! That is likely the issue. Widdle that down to 4 or 5 things and your problem will be solved.

I'll create a forced limit very soon.

Feel free to delete your information from this issue as well if you like. No need for all of this to be here.

Thanks, Zach

-- Zach Tratar ztratar@gmail.com - 630.854.8826

zachtratar.com

On Mon, Mar 31, 2014 at 4:26 PM, Jordan Suchow notifications@github.comwrote:

This issue is getting kind of personal, ha. Topics to favorite:

cognitive science, cognitive psychology, harvard psychology, cognitive neuroscience, phantom limbs, v.s. ramachandran, oliver sacks, synesthesia, the flame challenge, neil degrasse tyson, computational cognitive science, harvard vision lab, harvard visionlab, silencing illusion, david foster wallace, consider the lobster, visual working memory, cultural evolution, network science, experimental philosophy, theory of mind, dirichlet process, paul erdos, freakonomics, daniel kahneman, amos tversky, behavioral economics, neuropsychology, neurophysiology, hemifield neglect, base rate neglect, bayesian cognition, markov chain monte carlo, the wire, the sopranos, prosopagnosia, face blindness

There are no blacklisted words.

Yes, my avatar shows up:

[image: screen shot 2014-03-31 at 7 23 15 pm]https://cloud.githubusercontent.com/assets/613981/2574131/898a25ca-b92b-11e3-945b-4250e592c965.jpg

[image: screen shot 2014-03-31 at 7 26 02 pm]https://cloud.githubusercontent.com/assets/613981/2574143/dcb056ac-b92b-11e3-8cea-7a4ce4442647.jpg

You'll see the warning two comments ago, pasted at the end. I'll paste it here, too:

event.returnValue is deprecated. Please use the standard event.preventDefault() instead.

Reply to this email directly or view it on GitHubhttps://github.com/ztratar/followr/issues/3#issuecomment-39154688 .

suchow commented 10 years ago

Okay, yes, I can confirm that this is the issue. When I delete all the terms except for a few, the problem goes away. Thanks.

Much better than enforcing a limit would be to randomly select a handful of terms to use on each iteration. Even better would be to cycle through the terms so that there's an even spread. This behavior would make it possible to people focus on terms that are low frequency but highly targeted to their interests, as opposed to general things like "science" and "kittens" that will return many unrelated tweets.

ztratar commented 10 years ago

Good idea... I can make that happen, or could use some help if you want to pitch in ;D

The world can never have enough science or kittens.

-- Zach Tratar ztratar@gmail.com - 630.854.8826

zachtratar.com

On Mon, Mar 31, 2014 at 4:37 PM, Jordan Suchow notifications@github.comwrote:

Okay, yes, I can confirm that this is the issue. When I delete all the terms except for a few, the problem goes away. Thanks.

Much better than enforcing a limit would be to randomly select a handful of terms to use on each iteration. Even better would be to cycle through the terms so that there's an even spread. This behavior would make it possible to people focus on terms that are low frequency but highly targeted to their interests, as opposed to general things like "science" and "kittens" that will return many unrelated tweets.

Reply to this email directly or view it on GitHubhttps://github.com/ztratar/followr/issues/3#issuecomment-39155373 .