search

ztsv-av / spellbook

Shortcuts to your ML workflow!
4 stars 1 forks source link

FIX FORMATTING #17

Closed powerswing closed 3 years ago

powerswing commented 3 years ago

This PR fixes formatting in scripts mentioned in #16.

ztsv-av commented 3 years ago
  1. saveImage2Numpy (before loadJPGToNumpy) does not save a numpy array, it loads an image and converts it to numpy array and returns it. I think we can change parameters from (filename, dir, image_type) to (path, image_type)
  2. visualizeImage_Box rename to visualizeImageBox. Also, in the description it says "...should be in the following format: [xmin, ymin, xmax, ymax, ...]". The box format should be "[ymin, xmin, ymax, xmax, ...]"
powerswing commented 3 years ago
  1. saveImage2Numpy (before loadJPGToNumpy) does not save a numpy array, it loads an image and converts it to numpy array and returns it. I think we can change parameters from (filename, dir, image_type) to (path, image_type)
  2. visualizeImage_Box rename to visualizeImageBox. Also, in the description it says "...should be in the following format: [xmin, ymin, xmax, ymax, ...]". The box format should be "[ymin, xmin, ymax, xmax, ...]"

addressed both issues - next time use suggestions

powerswing commented 3 years ago

i think we can safely merge this - i haven't changed much code-wise (only argument positions in some functions and function names)

this may throw errors when running functions that depend on those functions but this will be easily fixed

ztsv-av commented 3 years ago

reviewed and discussed.