search

zturtleman / mm3d

Maverick Model 3D is a 3D model editor and animator for games.
https://clover.moe/mm3d
GNU General Public License v2.0
114 stars 22 forks source link

model_op.cc "equivalent" omits model-> #123

Open m-7761 opened 4 years ago

m-7761 commented 4 years ago

I noticed this block that compares models is comparing the first with itself...

https://github.com/zturtleman/mm3d/blob/ebbf3bb1951aa5f7e3617a2bce208fb5bf98b91d/src/libmm3d/model_ops.cc#L571-L642

The code here is pretty screwball too... I am looking at removing getSkelAnimKeyframe that it is the only user of. I don't know the history/usefulness of this feature. E.g. is it meant to compare two animations that are identical but use completely different conventions? Is it for unit-testing? Maybe the tests folder.

The frame animation just compares the data, which seems like the best way unless the hierarchical transforms are at issue.

m-7761 commented 4 years ago

Funnily there are propEqual members on most objects that do functionally the same thing. I wonder what is the difference? which is preferred/obsolete?