zturtleman / mm3d

Maverick Model 3D is a 3D model editor and animator for games.
https://clover.moe/mm3d
GNU General Public License v2.0
114 stars 22 forks source link

applyMatrix for joints looks all wrong to me #131

Open m-7761 opened 4 years ago

m-7761 commented 4 years ago

https://github.com/mick-p1982/mm3d/blob/1cfbf218029d7e2a31dde6ee8f74b84c22617cec/src/libmm3d/model.cc#L1850-L1879

Looking more closely at this code I can't see how it's possibly correct.

I guess I will have to rewrite it from scratch. applyMatrix is the last thing on my list before I can publish (purge myself of) the work I've been doing for much too long.

Normally changes made to joints don't propagate down to children. This code is modifying all of the children (or all if "global") but not the selected joints themselves.

Doing a simple test with Maverick using the Selected option on all joints produces a different rotation from the Global option.