zturtleman / mm3d

Maverick Model 3D is a 3D model editor and animator for games.
https://clover.moe/mm3d
GNU General Public License v2.0
114 stars 22 forks source link

Group smoothness and max angle doesn't affect vertex frame animations #139

Open zturtleman opened 4 years ago

zturtleman commented 4 years ago

Vertex normals for frame animations are always averaged regardless of the group smoothness and max angle settings.

May want to check max angle with the default pose so it matches skeletal models? [unconfirmed]

It seems necessary to add a new method to Model class to get frame animated vertex normal per-triangle (or group) and update the model exporters (MD2, MD3, ...) to use it.

m-7761 commented 4 years ago

I've solved this in my fork by greatly simplifying Model to use one set of normals everywhere, no mode switching. But it does have the side effect of smoothing changes depending on the animation time (because normals change) if that wasn't ever the case for skeletal animation. I.e. the angle threshold means two faces may have a smooth angle at one time and not at other times.