Closed m-7761 closed 3 years ago
Here (https://github.com/zturtleman/mm3d/blob/dcb15f3440a62376ed2e09d01960b58426c13ef6/src/implui/texturecoord.cc#L193) is another instance of this.
BTW: I looked at getTriangleGroup... the comments:
// FIXME cache current texture value and don't change it if we // don't have to (to prevent resetting zoom and center)
Aren't kidding. That's ridiculously work intensive. I think just doing it for the first triangle should suffice until there is a decent organizing principle.
Mick Pearson wrote:
Here (
https://github.com/zturtleman/mm3d/blob/dcb15f3440a62376ed2e09d01960b58426c13ef6/src/implui/texturecoord.cc#L193 ) is another instance of this.
Thanks. Fixed in ebdd607a40e780089e5ed9e4c8b764e0df1d6197.
https://github.com/zturtleman/mm3d/blob/master/src/implui/painttexturewin.cc#L79 looks pretty bogus.
Note also that the
addTriangles
subroutine is used precisely once, and builds the same selection list that is done just prior to calling it.Maybe this is interesting, but I would like a second set of eyeballs while I'm rewriting this code. Is this feature working accordingly?
EDITED: What I suspect is happening is the
foundTexture
is normally satisfied by the first triangle. If not the loop achieves nothing.