search

zturtleman / spearmint

Spearmint — an updated id Tech 3 engine for continuing the classics and creating new games.
https://clover.moe/spearmint
GNU General Public License v3.0
239 stars 27 forks source link

Network extended ASCII codes and '%'? #184

Closed zturtleman closed 9 years ago

zturtleman commented 10 years ago

In msg.c, ioq3 filters out characters > 127 and '%' (replaced with '.'). World of Padman allows char != 0xFF and != '%'. I think all values would be needed for UTF-8.

The comments say they're filtered out because "because old clients don't like them".

Should '%' be replaced with "%%" to avoid format issues? Would msg.c need to be aware of UTF-8 for this?

zturtleman commented 9 years ago

iostvef removes the filters.

zturtleman commented 9 years ago

I made string value more than 127 networkable. '%' is still not, and is not required for UTF-8 (aside from '%' itself). And no, cannot cover it to %% as that only works if it's the format string which is not suppose to happen.

UTF-8 doesn't use 0xFF, I didn't think about removing it until re-reading this issue. Though I do not know why World of Padman removes it.