search

zuavra / nginx-ip-whitelister

Backend for ngx_http_auth_request_module that whitelists remote IP address if a key is presented in URL.
MIT License
42 stars 3 forks source link

TypeError: URL is not a constructor #29

Closed chrisfeghali closed 4 months ago

chrisfeghali commented 4 months ago

Haven't looked into it yet, but getting the following after the changes yesterday. Using the docker container btw.

TypeError: URL is not a constructor
    at Server.<anonymous> (file:///opt/nginx-iw/node_modules/crumbware/index.js:27:27)
    at Server.emit (node:events:518:28)
    at parserOnIncoming (node:_http_server:1137:12)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17) Unhandled promise: Promise {
  <rejected> TypeError: URL is not a constructor
      at Server.<anonymous> (file:///opt/nginx-iw/node_modules/crumbware/index.js:27:27)
      at Server.emit (node:events:518:28)
      at parserOnIncoming (node:_http_server:1137:12)
      at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
}
zuavra commented 4 months ago

Hi @chrisfeghali, thank you for raising this, my test environment was still on 1.4.x and wasn't testing 1.5.x at all. :sweat_smile: Please upgrade to 1.5.1 (also caught another bug in the process). I've also published a docker image so you can use the :1.5.1 or :latest image tags.

chrisfeghali commented 4 months ago

No worries! Thanks for the quick resolution 🙂