Chef 14 compatibility - Githubissues

zuazo / dovecot-cookbook

Chef cookbook to install and configure Dovecot.

https://supermarket.chef.io/cookbooks/dovecot

Apache License 2.0

26 stars 33 forks source link

Chef 14 compatibility #32

Closed ledgr closed 6 years ago

ledgr commented 6 years ago

Description

Chef 12 is deprecated as of 2018 April. This PR updates dovecot-cookbook to be compatible with Chef 14

Issues Resolved

[x] Remove old dovecot Ohai plugin version
[x] Remove gem version locks in metadata.rb
[x] Update platform versions and review old ones (preferably supported by Fauxhai)
[x] Update tests after upgrading
[x] Update Travis integration tests matrix

Contribution Check List

[X] All tests pass.
[X] New functionality includes testing.
[X] New functionality has been documented in the README and metadata if applicable.

See CONTRIBUTING.md.

NOTES

Ohai dependency will have to be removed for Chef 15 to work.
Service provider conditional selection is moved from attributes to recipe/service.rb. Keeping condition in attributes return Class object instead of class path making serverspec tests to fail

ledgr commented 6 years ago

Fixes: https://github.com/zuazo/dovecot-cookbook/issues/30

ledgr commented 6 years ago

Compatible with Chef 12 and Chef 13.

coveralls commented 6 years ago

Coverage decreased (-0.005%) to 99.829% when pulling 9b2f69fb87eefa85afdbda8915ae47db96af4e43 on ledgr:master into 5550014d0b4aba61b8784530550c1d0c192d07b4 on zuazo:master.

ledgr commented 6 years ago

Okay, I'm really not sure why it reports:

Untouched Resources:

  directory[/etc/dovecot/.]          dovecot/recipes/conf_files.rb:32

If test passes:

.  avoids the creation of /etc/dovecot/. (with dot) directory

I might take a look into it after a few days.

lamont-granquist commented 6 years ago

@zuazo you might want to send this cookbook over to sous-chef if you want help maintaining it for new chef releases, etc and for stuff like this (you can join the sous-chef org and still be primary maintainer if you like...)

zuazo commented 6 years ago

Wow! Amazing work @ledgr! Thank you very much!

Give me a couple of days to review it. I also need to check the other PR about ohai. On Sunday I'm gonna start reviewing all those pending PRs.

ledgr commented 6 years ago

@zuazo @lamont-granquist I have changed attribute precedence levels in tests, and I have put back version locks in Gemfile.

ledgr commented 6 years ago

🎉 thank you 😄