Non unicode input - Githubissues

zub2 / dotprint

Produce PDF output out of text files with dot matrix printer escapes.

GNU General Public License v3.0

22 stars 5 forks source link

Non unicode input #5

Closed pkess closed 4 years ago

pkess commented 4 years ago

Here we go with my suggestion to implement the codepage translation inside of dotprint. I think the work on this pr is mostly done. Last open point from my side is to implement a dynamic load mechanism for the codepage translation as you already implemented in your cp2utf8 project.

zub2 commented 4 years ago

I see I created a conflict for you when I merged pull request #4. I'm sorry about this. :-(

Are you planning to implement the actual conversion in this MR? If not, I can take care of the conflict, merge your pull request and either me or you can then continue the work.

pkess commented 4 years ago

Ok, i implemented a support for codepage translation inside of dotprint now. Hope you like those changes. Otherwise feel free to give me feedback so i can improve it. The same translation files as in your cp2utf8 can be used. Open points and questions:

should we copy the translation files here? And if so: where to put them?
Can you provide the test files in their original codepage?

zub2 commented 4 years ago

I converted my test files to the original encoding in 662aba17ab31ca98e026dd25749cecd942e35f0a (in master). As far as the conversion tables are concerned, feel free to copy them, at least for now. Into something like data/ or tabes/.

zub2 commented 4 years ago

Thank you for all the work you invested in this!