search

zufardhiyaulhaq / istio-ratelimit-operator

Automatically create global & local rate limit in Istio, support EnvoyFilter versioning, ratelimit metrics, shadow mode, and ratelimit based on route!
MIT License
40 stars 9 forks source link

[FEATURE] Configure rate limit service image location #15

Closed scrollins closed 2 years ago

scrollins commented 2 years ago

I was looking at the RateLimitService CRD and it looks like you've hardcoded the rate limit service image to be pulled from zufardhiyaulhaq/ratelimit:v1.0.0 I did try specifying the container just to test out my theory 

     "container" = {
          image             = "${MY_AWS_ACCOUNT_ID}.dkr.ecr.us-east-1.amazonaws.com/envoyproxy-ratelimit:8d6488ea"
          image_pull_policy = "Always"
          command           = ["/bin/ratelimit"]
        }

Can you verify that my assessment is correct or I've missed something. Thanks

zufardhiyaulhaq commented 2 years ago

Hi, the image is actually forked with versioning from https://github.com/envoyproxy/ratelimit for now, it's hardcoded to zufardhiyaulhaq/ratelimit:v1.0.0 but it's should be possible to make that configurable.

https://github.com/zufardhiyaulhaq/istio-ratelimit-operator/blob/master/pkg/service/deployment_builder.go#L25-L51

scrollins commented 2 years ago

Ok. I'll try to throw up a PR this week and add that as a param. Thanks for the pointer

deferraz commented 2 years ago

Hi I've created this PR https://github.com/zufardhiyaulhaq/istio-ratelimit-operator/pull/19, I want to know if this is something that you think is the best way to configure the image/tag for RateLimitService @zufardhiyaulhaq, I've tried to label as work in progress but looks like I can't do, sorry