Closed deferraz closed 2 years ago
I think rather than adding it to the CRDs, can we add that to the operator environment variable? cc @deferraz it's more clear and simple.
I think rather than adding it to the CRDs, can we add that to the operator environment variable? cc @deferraz it's more clear and simple.
Hi @zufardhiyaulhaq! Sure we can, what's your idea? Maybe I can try to implement it, can you elaborate more on your idea? My reasoning behind including inside the RatelimitService was to be flexible enough if you want to try the same set of rate rules but with different releases of the Ratelimit GRPC project
make sense @deferraz , let me merge this and fix several things on master.
Summary
This PR includes two new properties for RateLimitService Spec inside Kubernetes object Image and ImageTag, this is necessary if we need to adjust the image of the RateLimitService that will be deployed by the RateLimitController
Type of Change
This PR fixes/implements the following bugs/features:
Test
ratelimitservice manifest file:
After applying the RatelimitService/GlobalRatelimitConfig/GlobalRatelimit the deployment of the service:
Closes #15