Completion has some problems

koke2c95 commented 6 years ago

I use many many editors，unfortunately there is no effect I want :( So I found this . Is awesome, assembly is fully been rendered, This makes it not look like a pile of junk :)

However, this has the bug. that it will complete your input ,no matter what if enter or blank, caused unwanted content.

assembly some did not render

mahotilo commented 6 years ago

You can adjust auto complete function via menu Settings | Auto complete | ...

koke2c95 commented 6 years ago

@mahotilo here is my setting

mahotilo commented 6 years ago

Can you exactly describe situation that annoy you? E.g., I found "Close Braces" auto complete totally uncomfortable, so I switched it off. Maybe, "Complete Words" is problem in your case?

zufuliu commented 6 years ago

I added a wiki article Auto Completion in Notepad2, please read it and help me to improve these articles.

By the way, the assembler instructions for x86_64 or other architecture is not complete.

koke2c95 commented 6 years ago

OK, after reading your wiki, so I writing about this requirements .

These functional are required for modern editors

Metro UI
Unlimited undo and redo
Repeat word completion
The current row number and the same string when the box needs to be highlighted
Code page automatic recognition conversion
Automatically identify hyperlinks and highlight them
Powerful search and replace function
Personalized fonts and skin menus, etc.
Support for multiple documents to open
Automatic temporary Save
Enhancements: built-in command line
Support line number display
High-efficiency editing operation: block box selection

Use universal shortcuts:

Ctrl+f, Ctrl+h Find, Replace Window
Ctrl+g to the number of rows
Shift+Alt block box selection

These functional are required for code editor

Can identify file types by suffix
Word highlighting and completion (lexer)
Function and syntax navigation and support for statement folding (syntax)
Automatic Indentation and follow Language Format Specifications
completion of punctuation
Add-ones function

TODO...

zufuliu commented 6 years ago

Some of these are already supported:

Unlimited undo and redo. This depends on Scintilla, Notepad2 doesn't set undo limit.
Code page automatic recognition conversion. File encoding auto detection if performed when open file. Encoding conversion is available in menu File -> Encoding.
Powerful search and replace function. POSIX RegExp is supported for search.
Personalized fonts and skin menus, etc. Font can be changed var menu View -> Default Font. Scheme style can be customized var View -> Customize Schemes.
Line number (Ln), column index (Col) in current line, character index (Ch) in cureent line, selected byte / character count (Sel), selected line count (SelLn), repeated count of current selected/finding content (Fnd) is displayed in status bar.
Ctrl+F, Ctrl+H Find and Replace. Find and Replace is in Edit menu.
Ctrl+G to the number of rows. Goto in Edit menu
Can identify file types by suffix. Already supported, file extension for each scheme can be customized.
Word highlighting and completion (lexer). Supported some, not powerful as an IDE.
Automatic Indentation. Not full supported.
Block box selection. This is called Rectangle selection in Scintilla, can be archived by hold down Alt key before select.

koke2c95 commented 6 years ago

I tried use Alt to block box selection, unfortunately it crashed :( here is dump file，it show x86 code is incompatible.

FAULTING_IP: 
+bfb0efd130
00000000`00000000 ??              ???

EXCEPTION_RECORD:  ffffffffffffffff -- (.exr 0xffffffffffffffff)
ExceptionAddress: 0000000000000000
   ExceptionCode: 80000003 (Break instruction exception)
  ExceptionFlags: 00000000
NumberParameters: 0

CONTEXT:  0000000000000000 -- (.cxr 0x0;r)
rax=000000000075e3c0 rbx=0000000000000001 rcx=0000000000000010
rdx=000000000075e390 rsi=0000000000000000 rdi=00000000000002b4
rip=0000000076f42772 rsp=000000000075ebd8 rbp=000000000085f074
 r8=000000000085f0d0  r9=0000000000000004 r10=ffffffffffffffff
r11=000000000085f0d0 r12=00000000ff04d000 r13=000000000075fdb0
r14=000000000085f008 r15=0000000076f41f30
iopl=0         nv up ei pl nz na pe nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00000202
wow64cpu!TurboDispatchJumpAddressEnd+0x598:
00000000`76f42772 c3              ret

FAULTING_THREAD:  000000000000058c

DEFAULT_BUCKET_ID:  STATUS_BREAKPOINT

PROCESS_NAME:  Notepad2.exe

ERROR_CODE: (NTSTATUS) 0x80000003 - {

EXCEPTION_CODE: (NTSTATUS) 0x80000003 (2147483651) - {

NTGLOBALFLAG:  0

APPLICATION_VERIFIER_FLAGS:  0

APP:  notepad2.exe

ANALYSIS_VERSION: 6.3.9600.16384 (debuggers(dbg).130821-1623) amd64fre

PRIMARY_PROBLEM_CLASS:  STATUS_BREAKPOINT

BUGCHECK_STR:  APPLICATION_FAULT_STATUS_BREAKPOINT

LAST_CONTROL_TRANSFER:  from 0000000076f425be to 0000000076f42772

STACK_TEXT:  
00000000`0075ebd8 00000000`76f425be : 00000023`76ffb69c 00000000`00000023 00000000`00000001 00000000`0085f2bc : wow64cpu!TurboDispatchJumpAddressEnd+0x598
00000000`0075ebe0 00000000`76f0323a : 00000000`00000000 00000000`76f41503 00000000`00000000 00000000`76f03420 : wow64cpu!TurboDispatchJumpAddressEnd+0x3e4
00000000`0075ec90 00000000`76f0317e : 00000000`00000000 00000000`00000000 00000000`0075fd30 00000000`0075f600 : wow64!Wow64LdrpInitialize+0x22e
00000000`0075ece0 00007fff`28adaa9b : 00000000`00b70108 00000000`00000000 00000000`00000010 00000000`ff046000 : wow64!Wow64LdrpInitialize+0x172
00000000`0075f220 00007fff`28ab97aa : 00007fff`28a10000 00000000`00000000 00000000`00000000 00000000`ff046000 : ntdll!LdrpInitializeProcess+0x157b
00000000`0075f540 00007fff`28a26aa6 : 00000000`0075f600 00000000`00000000 00000000`00000000 00000000`ff046000 : ntdll!_LdrpInitialize+0x92cb2
00000000`0075f5b0 00000000`00000000 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ntdll!LdrInitializeThunk+0xe

FOLLOWUP_IP: 
wow64cpu!TurboDispatchJumpAddressEnd+598
00000000`76f42772 c3              ret

SYMBOL_STACK_INDEX:  0

SYMBOL_NAME:  wow64cpu!TurboDispatchJumpAddressEnd+598

FOLLOWUP_NAME:  MachineOwner

MODULE_NAME: wow64cpu

IMAGE_NAME:  wow64cpu.dll

DEBUG_FLR_IMAGE_TIMESTAMP:  5215f8c4

STACK_COMMAND:  dt ntdll!LdrpLastDllInitializer BaseDllName ; dt ntdll!LdrpFailureData ; ~0s; .ecxr ; kb

FAILURE_BUCKET_ID:  STATUS_BREAKPOINT_80000003_wow64cpu.dll!TurboDispatchJumpAddressEnd

BUCKET_ID:  APPLICATION_FAULT_STATUS_BREAKPOINT_wow64cpu!TurboDispatchJumpAddressEnd+598

ANALYSIS_SOURCE:  UM

FAILURE_ID_HASH_STRING:  um:status_breakpoint_80000003_wow64cpu.dll!turbodispatchjumpaddressend

FAILURE_ID_HASH:  {6f103643-6db7-2900-fabf-c6c0445c63f9}

Followup: MachineOwner

zufuliu commented 6 years ago

It's the Alt key not Tab. Tab is used to add \t (which can be converted to spaces depends on you settings in Settings -> Tab Settings) or indent selected text.

zufuliu commented 5 years ago

The "Auto Completion Settings" dialog is added.

zufuliu / notepad4