search

zufuliu / notepad4

Notepad4 (Notepad2⨯2, Notepad2++) is a light-weight Scintilla based text editor for Windows with syntax highlighting, code folding, auto-completion and API list for many programming languages and documents, bundled with file browser plugin matepath.
Other
2.56k stars 179 forks source link

missing file: tools/lang/wasm-lexer-keywords.txt #748

Closed lifenjoiner closed 7 months ago

lifenjoiner commented 7 months ago

Run KeywordUpdate.py. You will get missing file: lang/wasm-lexer-keywords.txt message and src/EditLexers/stlWASM.c ruined.

zufuliu commented 7 months ago

It's this file https://github.com/WebAssembly/wabt/blob/main/src/lexer-keywords.txt

https://github.com/zufuliu/notepad2/blob/3e7180269e00fb562d55e9aaf26aab69eac79ec2/tools/KeywordUpdate.py#L109-L110

lifenjoiner commented 7 months ago

OK. Didn't dive in to see the comments.

lifenjoiner commented 7 months ago

Feedback: I downloaded the latest lexer-keywords.txt and then run KeywordUpdate.py. It yielded differences. We may not on the same commit. And tools/lang/wasm-lexer-keywords.txt showed up in git changed file list, costing a bit more operations to exclude it when you work on different branches.

zufuliu commented 7 months ago

after 3e7180269e00fb562d55e9aaf26aab69eac79ec2, updating to stlWASM.c is skipped when tools/lang/wasm-lexer-keywords.txt is missing, also it's not tracked by git:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        build/mingw/build_clang.bat
        build/mingw/build_gcc.bat
        scintilla/EastAsianWidth.h
        scintilla/ExtVector.h
        tools/lang/CIL.il
        tools/lang/VBScript.vbs
        tools/lang/VisualBasic.vb
        tools/lang/wasm-lexer-keywords.txt
lifenjoiner commented 7 months ago

Didn't mention that I was in git gui mode. After the fix, it's good that I don't need to care about wasm-lexer-keywords.txt normally.