zufuliu / notepad4

Notepad4 (Notepad2⨯2, Notepad2++) is a light-weight Scintilla based text editor for Windows with syntax highlighting, code folding, auto-completion and API list for many programming languages and documents, bundled with file browser plugin matepath.
Other
3.39k stars 214 forks source link

Can't change the scroll bar color #807

Open J-PRS opened 4 months ago

J-PRS commented 4 months ago

It would complete the dark theme look.

2024-06-29_15-22-Notepad2_y5c8NBR3Uz

Matteo-Nigro commented 4 months ago

The same goes for the toolbar background but this would probably require redesigning some icons to improve readability with this theme. If needed as done in the past for the adaptation of the icons I am available.

J-PRS commented 4 months ago

Yeah, though I've never used the icons, and the menu only for changing settings, so just the bar would be enough for me. Minimum viable fully dark themed product.

Jackarain commented 3 months ago

Hi, 我已经尝试整合三方的代码,修改了一个 dark theme 的版本(DarkMode 分支),主要就是针对上面所提到的 toolbar 和 menubar 以及 scroll bar 在 darkmode 的问题,运行效果如下图:

image

Matteo-Nigro commented 3 months ago

I confirm that if this is implemented in Notepad4 the icons will have to be revised.

zufuliu commented 3 months ago

Hi, 我已经尝试整合三方的代码,修改了一个 dark theme 的版本

Your code uses std::mutex, the exe is not granted to be runnable on earlier system, see https://github.com/microsoft/STL/issues/946. https://github.com/zufuliu/notepad4/blob/01d55f321a6394ba2d4f3702da9af8d490de7ebc/scintilla/src/ParallelSupport.h#L39-L43

Jackarain commented 3 months ago

感谢 @zufuliu 指出,让我了解到 msvcstd::mutex 已经放弃支持在更早的 windows 版本上运行。

不过需要说明的是,那并不是我写的代码,我只是简单的整合了人家的代码(最初作者:https://github.com/ysc3839/win32-darkmode/)到 notepad4 中以达到基本界面能拥有的 Dark 效果。

antnesswcm commented 1 month ago

image

暗色主题,不能完全覆盖UI太难受了,何时能够用上呀😥