search

zugaldia / android-robocar

Build your own robocar, remote-controlled or autonomous, with Android Things.
BSD 2-Clause "Simplified" License
94 stars 21 forks source link

Implemented wide turns while moving forward or backward as opposed to in-place turns #16

Closed hsalameh closed 7 years ago

zugaldia commented 7 years ago

@hsalameh Thank you very much for the contribution! From what I can see, the Robocar is much more responsive this way. I'll review your PR shortly, meanwhile I fixed our CI to make sure it's triggered with your PR too.

hsalameh commented 7 years ago

It could use some refactoring to make the code clearer. I will get to it tonight. Also regarding formatting, I tried the Android Studio default and formatted one file but it changed a lot of things. What's the best way to format the code before committing?

zugaldia commented 7 years ago

Also regarding formatting, I tried the Android Studio default and formatted one file but it changed a lot of things. What's the best way to format the code before committing?

We're gonna eventually use checkstyle but it hasn't been fully set up yet https://github.com/zugaldia/android-robocar/issues/17.

Don't worry about it for now, thanks again for the contribution. I'll go ahead and merge as is right now (so that we can show this during DevFestDC later this week) and we'll work on some refactoring / cleaning later on.