search

zuhao / plotrb

A plotting library in Ruby built on top of Vega and D3.
Other
42 stars 12 forks source link

Turn Transform methods not handling state into a module #5

Open pjotrp opened 11 years ago

pjotrp commented 11 years ago

The transform methods do not need to keep track of state. I would make this a module, so as to force a more functional style. All you are using is the type, which can be passed in with every method, or fetched from the surrounding class(name). If you need state, add a separate state class and include the module.

Split out methods that can be 'pure' from methods that really need 'state'.

pjotrp commented 11 years ago

OK, you are also tracking properties. Let me rephrase what I wrote: put all methods that are not handling state into a separate module.