fix: translations and gridview overflow bugfix

zulfahmi93 / month-year-picker

Material picker for selecting month and year.

MIT License

16 stars 119 forks source link

fix: translations and gridview overflow bugfix #2

Closed Kingtous closed 2 years ago

Kingtous commented 2 years ago

add: Chinese translation
fix: GridView overflow problem(change to Wrap)
- GridView buttons will overflow the area of the PageView, regardless of the translations.

zulfahmi93 commented 2 years ago

Thanks for the PR! Can you please open a separate PR for the translation?

For the overflow issue, your PR introduces other issues where:

The highlighted month/year is not in a circular shape (it became a rounded rectangle)
Loss of left padding
In LTR locale (I tested using English and Malay), the list month only from 1-9. 10-12 do not show up.

This screenshot I tested on iPhone XS (iOS 15.4.1):

zulfahmi93 commented 2 years ago

Merged with this commit. (Only the localisation)

Kingtous commented 2 years ago

Sorry, I forget it due to being dramatically busy for several months. Thanks for creating a new commit to add zh_cn translation to this wonderful open source project! :)