search

zulfahmi93 / month-year-picker

Material picker for selecting month and year.
MIT License
16 stars 119 forks source link

Update dialogs.dart #7

Closed laminr closed 2 years ago

laminr commented 2 years ago

removing ! to WidgetsBinding.instance

zulfahmi93 commented 2 years ago

This change will cause the package to be incompatible with the users who haven't upgraded their SDK to Flutter 3.

laminr commented 2 years ago

can't you release it under a new version?

zulfahmi93 commented 2 years ago

Yes, I can. But you also need to update the Dart SDK constraint inside the pubspec.yaml to ensure that the users who haven't updated to Flutter 3 SDK will not be upgraded automatically to the newest package version.

laminr commented 2 years ago

I have updated to +4. is that what was needed?

zulfahmi93 commented 2 years ago

Since this is a public API change introduced with the Flutter 3 SDK, we need to:

  1. Update the versioning from 0.1.0 to 0.2.0. Since the pub client uses semantic versioning, the existing users using version 0.1.0 of this package should not be upgraded automatically to version 0.2.0.
  2. Update the Dart SDK constraint from 2.12.0 to 2.17.0.
  3. Update the Flutter SDK constraint from 2.0.0 to 3.0.0.
  4. Update the README.md's Building From Source section to reflect the new SDK constraints changes.

You can refer to the latest commit that I've pushed.

I'll close your PR for now. Thanks for the contribution!