search

zulip / docker-zulip

Container configurations, images, and examples for Zulip.
https://zulip.com/
Apache License 2.0
550 stars 227 forks source link

Integrate/document helm configuration from zulip-helm #117

Open timabbott opened 6 years ago

timabbott commented 6 years ago

@armooo did some good work on using Helm with this project, located here: https://github.com/armooo/zulip-helm.

We should integrate that with this project (at the very least, writing a nice HOWTO guide for using that to run Zulip inside Kubernetes easily)

ayushin commented 3 years ago

just found this!

Is there any work on this?

We are trying to run zulip in production and the current setup with supervisor in docker is really really outdated (we run k8s on multiple providers with terraform).

I am not sure what the right way forward should be as the super-hairy entrypoint parsing env variables into files could be replaced with kubernettes configmaps and secrets, but also all the processes would need to be split into separate docker images.

@timabbott are there any plans for creating a more modern deployment setup perhaps with k8s helm and a terraform module out of the box?

I understand that changes things completely for the entire dev team, but if you don't do this at some point this will make the whole project dev-ops hopelessly outdated and increasingly difficult to maintain.

bmalynovytch commented 3 years ago

I should be working on a complete rewrite in a couple of weeks / months. If somebody wants to give a first try, it's also possible to use https://kompose.io/ to convert the docker-compose into a naive set of Helm definition files.

bmalynovytch commented 3 years ago

A first work is in progress, where should I drop it ? (different repo ? specific path here ?)

timabbott commented 3 years ago

I think probably a PR on this repository is reasonable unless there's a structural reason in the Helm world to do dedicated repositories -- it makes versioning easier to have a single main branch.

We're very happy to accept a community contribution on this front especially if someone's willing to commit to look at future bug reports for it; at the moment we don't have someone on the core team spending a lot of active time on Docker and probably in any case users have more expertise with the Helm ecosystem than we do.

bmalynovytch commented 3 years ago

Usually, Helm charts are hosted on separate repositories, as they also require some CI to test, package and publish. Actually, the chart is still in early beta. I needed to do some dirty patches on the Docker image at runtime to fix some incompatibilities.

timabbott commented 3 years ago

OK -- want to stop by chat.zulip.org and we can talk through the changes you needed to make in #backend? Ideally we'd just get those fixed in the main repository.

ayushin commented 3 years ago

I've made some adaptations for Google Cloud Platform GKE - I'll be happy to share and also test.