shanzez
commented
3 months ago I think the issue is here: https://github.com/zulip/docker-zulip/blob/cd7692a7e6648e5a1da79fa71812428cd250b582/entrypoint.sh#L92
Not sure if that is the only place (since I'm not getting past that point). Something like this might work:
if [ -z "$TYPE" ]; then
case "$2" in
[Tt][Rr][Uu][Ee]|[Ff][Aa][Ll][Ss][Ee]|[Nn]one)
TYPE="bool"
;;
[1-9][0-9]*)
if [[ "$2" =~ ^[1-9][0-9]*$ ]]; then
TYPE="integer"
else
TYPE="string"
fi
;;
[\[\(]*[\]\)])
TYPE="array"
;;
*)
TYPE="string"
;;
esac
fiThe problem, I think, is that the case statement finds numbers in the value and classifies it as an integer. Since we cannot use regex in the case statement, I pushed it into that case item.
Example value in a docker-compose.yml: SETTING_SOCIAL_AUTH_GITHUB_KEY: 87ca9786478bf2d7021a
luckyraul
alexmv
I'm getting a failure on start-up when I set the following in my docker-compose.yml:
It appears that it is the
SETTING_SOCIAL_AUTH_GITHUB_KEYvalue. I see this in the docker log:I see, specifically:
But my key (i.e. Client ID) is not an integer. In fact, I checked 3 of my Client IDs and they all appear to be hex.
Later on in the log I see:
I will look back in the code to see if this has always been this way or if it was a recent change. Right now, I don't have a way around it.
Of course if I remove that setting from my docker-compose.yml, it loads up just fine, so it does appear to be that one value (SOCIAL_AUTH_GITHUB_KEY) that is causing the failure to load.