search

zulip / docker-zulip

Container configurations, images, and examples for Zulip.
https://zulip.com/
Apache License 2.0
574 stars 238 forks source link

Detect integer and non-integer (#435) #436

Closed shanzez closed 5 months ago

luckyraul commented 5 months ago

May be just revert as it was?

https://github.com/zulip/docker-zulip/commit/0d72546a4cb183c985de6d96873ac5508cfd3ce3

shanzez commented 5 months ago

Fine by me. The original change was intentional to correct something, of course. My suggested change will get us there.

mhkarimi1383 commented 5 months ago

@shanzez I think the regex is a bit problematic I have used another method here https://github.com/zulip/docker-zulip/pull/439

shanzez commented 5 months ago

@mhkarimi1383 I'm fine with whatever solution as long as it gets fixed 😊. I prefer regex, but not everyone does. If you have a use-case that you think would not work, I'm interested.