Added unbind_s, search_ext and result3 support; changed rename_s to work how python-ldap does

zulip / fakeldap

A fake ldap implementation to be used in unittests.

21 stars 24 forks source link

Added unbind_s, search_ext and result3 support; changed rename_s to work how python-ldap does #22

Open cmalek opened 3 years ago

cmalek commented 3 years ago

Hello

Thank you for your fakeldap module!

I've added a few things that we needed in order to test our code, and also did some PEP8 fixes to make my linter happy.

Added unbind_s support
Added search_ext and result3 support
Changed rename_s to work how python-ldap expects: rename_s(dn, newrdn, superior)
When using the argument list as a dict key, serialize the argument list with a bytes-aware JSON encoder. This fixes the "list is unhashable" , "bytes are unhashable", etc. problems

best wishes Chris

timabbott commented 3 years ago

If you can, it'd be nice if you can clean up the commits to follow the Zulip commit guidelines: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

We're less strict about them with this project (which we adopted some time ago), but I think it'd be quite helpful for reviewing this efficiently to have real commit messages.

@mateuszmandera I assume you'll take point on reviewing this (we should at the very least make sure it doesn't break the zulip/zulip test suite).

cmalek commented 3 years ago

Will do! Thank you for replying! I'd been using mock and patch on my LDAP test code for years, and using fakeldap is sooo much cleaner, so I appreciate your work here.

timabbott commented 3 years ago

@cmalek just a bump on cleaning up the commit history.

dill0wn commented 2 years ago

@cmalek Just a bump on this -- our team would be very happy to see this functionality merged :)

timabbott commented 1 year ago

This is a bit late of a reply, but @dill0wn or anyone else who comes across this, feel free to submit a new PR that cleans this up.

cmalek commented 1 year ago

I actually ended up writing my own project for this that did more of what I needed. https://python-ldap-faker.readthedocs.io/en/latest/