search

zulip / fakeldap

A fake ldap implementation to be used in unittests.
21 stars 24 forks source link

Fix reference to wrong repo in the README #26

Closed mateuszmandera closed 2 years ago

mateuszmandera commented 2 years ago

The repo is now zulip/fakeldap, so that instruction is outdated and incorrect

mateuszmandera commented 2 years ago

There are also some 30loops instances in the ldap examples - e.g. n=admin,dc=30loops,dc=net - not sure if we wanna change them to anything or not, since they're not exactly "wrong" like the piece of instructions this PR is fixing was

timabbott commented 2 years ago

Merged, after tweaking the commit message to make clear the old URL works via GitHub's redirect system.

I think ideally we'd use e.g. ldap.example.com for the domain in the LDAP examples rather than the name of the company that originally authored this software, since that's the intended purpose of the special example.com domain.