Get maintained bots to 100% test coverage.

[roberthoenig]

UPDATE Scroll down to the latest comments to find a list of the remaining bot files not at 100% coverage.

NOTE: All striked-through bots have been deprecated, all checked bots have been given tests. See the comments for more information on how to proceed.

We have a couple bots in zulip_bots/zulip_bots/bots that are untested:

- [ ] commute - [ ] foursquare - [ ] git_hub_comment - [ ] github

• [x] github_issues

- [ ] googlesearch - [ ] howdoi - [ ] john - [ ] youtube

For each bot, we should either

• add tests. You can find help in our guide for bot testing.

• deprecate the bot. If a bot seems to be bugged or completely useless, we should discuss it on chat.zulip.org and decide whether it is worth keeping.

[swekshajha12]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @swekshajha12! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[zulipbot]

Hello @swekshajha12, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[roberthoenig]

Update: All the original bots mentioned in this issue have either been deleted, deprecated, or given tests.

The next step here is to move the remaining bots in zulip_bots/bots to 100% test coverage. Currently, none of them is at 100%. Their coverage ranges from 50% - 95%, the mean is ~80%. Details can be found in the codecov coverage report.

[palash25]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @palash25! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[starlord1311]

@roberthoenig can i take up this issue?

[palash25]

@starlord1311 no I'm working on it if I can't complete it in the next 5 days I will be unassigned and then you can try

[KannaRaghava]

@zulipbot Claim

[ViRu-ThE-ViRuS]

@zulipbot claim

[zulipbot]

Hello @ViRu-ThE-ViRuS, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[sbshah97]

@roberthoenig is this Issue still under Progress?

[roberthoenig]

@salman-bhai this issue can be worked on by multiple people - claims with zulipbot do technically not make a lot of sense. Feel free to just choose a bot and improve its test coverage :)

[zulipbot]

Welcome to Zulip, @AmAnAgr! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[sbshah97]

Alright @roberthoenig thanks a lot !

[amanagr]

@zulipbot claim

[showell]

re-opening

[amanagr]

@zulipbot claim

[amanagr]

@zulipbot abandon

[zulipbot]

ERROR: This active issue has no assignee.

[zulipbot]

ERROR: This active issue has no assignee.

[roberthoenig]

Here is a list of remaining bot files not at 100% coverage:

• zulip_bots/zulip_bots/bots/connect_four/controller.py 99%
• zulip_bots/zulip_bots/bots/youtube/youtube.py 99%
• zulip_bots/zulip_bots/game_handler.py 99%
• zulip_bots/zulip_bots/bots/baremetrics/baremetrics.py 98%
• zulip_bots/zulip_bots/bots/giphy/giphy.py 98%
• zulip_bots/zulip_bots/bots/salesforce/salesforce.py 98%
• zulip_bots/zulip_bots/bots/link_shortener/link_shortener.py 97%
• zulip_bots/zulip_bots/bots/github_detail/github_detail.py 96%
• zulip_bots/zulip_bots/bots/yoda/yoda.py 95%
• zulip_bots/zulip_bots/bots/weather/weather.py 93%
• zulip_bots/zulip_bots/bots/xkcd/xkcd.py 90%
• zulip_bots/zulip_bots/bots/idonethis/idonethis.py 84%
• zulip_bots/zulip_bots/bots/mention/mention.py 74%
• zulip_bots/zulip_bots/bots/tictactoe/test_tictactoe.py 69%
• zulip_bots/zulip_bots/bots/chess/chess.py 68%
• zulip_bots/zulip_bots/bots/tictactoe/tictactoe.py 32%

[showell]

Do the ones at 97%-plus coverage have some common thing missing?

[amanagr]

Most of them require raising Exceptions after requests.get/post method.

[DhruvThakker]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @DhruvThakker! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[aliyareneekhan]

claim

[kishanlp]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @kishanlp! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!