provision: Refactor version tuple generation logic.

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

361 stars 362 forks source link

provision: Refactor version tuple generation logic. #484

Closed ujjwal-raizada closed 6 years ago

ujjwal-raizada commented 6 years ago

Previous tuple generation logic was throwing an error parsing version like 3.6.7rc1 because micro-versions like '7rc1' cannot be converted into integer.

Fix #482

ujjwal-raizada commented 6 years ago

@timabbott @rishig , I would really appreciate it if you could please review this one.

ujjwal-raizada commented 6 years ago

@timabbott Just updated this in response to your feedback.

timabbott commented 6 years ago

Nice, merged, thanks @ujjwalrox!