search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
361 stars 362 forks source link

Added --excluded-users and --excluded-terms options #487

Closed Hyaxia closed 5 years ago

Hyaxia commented 5 years ago

Relevant issue - https://github.com/zulip/python-zulip-api/issues/486

Any thing that will be entered in the --exclude string separated by a ',' will then be checked if it appears in the tweet. If it does then the tweet wont be sent.

timabbott commented 5 years ago

Can you also add an option for excluding messages with a given sender?

timabbott commented 5 years ago

Also, you should rebase this to clean it up to comply with Zulip's commit style. Check out our GitHub guide and commit guidelines for more details.

timabbott commented 5 years ago

(I did some basic testing on chat.zulip.org, and this does work for filtering worlds from the content of messages; but the main use case we have in mind is filtering messages sent by certain accounts, so we should add that.)

Hyaxia commented 5 years ago

@timabbott I hope this is what you ment by rebasing. If not, please provide me with further instructions as I don't seem to find any other way.

timabbott commented 5 years ago

Sorry for the slow review! This looks great, merged. Thanks for fixing!