bridge_with_irc: Check if the bot is subscribed to the relevant stream on startup.

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

361 stars 362 forks source link

bridge_with_irc: Check if the bot is subscribed to the relevant stream on startup. #500

Closed rht closed 4 years ago

rht commented 5 years ago

This way, the important precaution to make sure that the bot is subscribed is no longer necessary, since the bot will print out the problem itself.

orientor commented 4 years ago

@rht I saw your PR after making my PR. Our approaches are different though. I am checking it before initializing the bot. Also I have fully tested my PR. Kindly review.

rht commented 4 years ago

Regardless of where the check happens, IMO my solution is more concise. I did in 3 lines of what you did for checking the subscription. Sorry if I am biased, we need a 3rd party to break the tie. If @neiljp can take a look?

orientor commented 4 years ago

@rht yes you're right. BTW I tested your code and it works properly. So it can be merged.