search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
361 stars 362 forks source link

api: Implement GET /attachments endpoint #562

Closed akashaviator closed 4 years ago

akashaviator commented 4 years ago

This implements the GET /attachments endpoint.

akashaviator commented 4 years ago

@timabbott Can you have a look?

akashaviator commented 4 years ago

@timabbott Other such examples seemed to follow this style to represent the output, rather than being the exact copy pasted outputs. I don't add these without testing the endpoints manually though. I'll make sure to not produce such typos again :).

timabbott commented 4 years ago

Yeah, the ... is fine; I just mean the there's no space in attachments:[. Should be attachments: [

Also, please use periods at the end of your commit message titles.

akashaviator commented 4 years ago

@timabbott I have updated the PR.

timabbott commented 4 years ago

(Let me know when this is updated).