search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
354 stars 355 forks source link

bridge_with_irc: Make bridge more user-friendly. #564

Closed orientor closed 4 years ago

orientor commented 4 years ago

Edit error and success messages of zulip-irc bridge to be more user friendly. Also check whether zulip bot is subscribed before starting irc bot.

orientor commented 4 years ago

@rht @showell changed the messages displayed on running irc-bot. Kindly review.

rht commented 4 years ago

The commit message has redundant description of "bridge_with_irc" and "zulip-irc bridge".

showell commented 4 years ago

@rht Once you're happy with this, I'll merge it. Everything here seems pretty reasonable to me.

@orientor Thanks for the quick turnaround here! Can you address the comment about the commit message?

showell commented 4 years ago

@rht For the redundancy bit, what's your suggested edit to the commit message?

rht commented 4 years ago

For the commit message, I was thinking of along the line of "bridge_with_irc: Improve user-friendliness"; everything else LGTM.

orientor commented 4 years ago

Changed the commit message.