zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
353 stars 355 forks source link

Audit expressions formerly assigned to unused variables #590

Open andersk opened 4 years ago

andersk commented 4 years ago

Flake8 (#588) revealed a number of unused variable assignments. I removed the unused variables in these commits:

54b257820481d39d2b38c60b1ca019a495270771 cleanup: Remove unused variables. a01e5e37f42971db042f042726040d283efec857 cleanup: Remove more unused variables.

However, I conservatively avoided removing the expressions that had been assigned to the variables, so this left behind expression statements that are probably unused unless they have important side effects. We should audit them to see if we can remove them and/or if there are deeper bugs here.