api: Update type annotation in 'remove_subscriptions'.

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

353 stars 355 forks source link

Closed akashaviator closed 4 years ago

akashaviator commented 4 years ago

This updates the type annotation for the 'principals' argument to accept list of email addresses as well as user ids.

akashaviator commented 4 years ago

@timabbott I've updated the PR.

akashaviator commented 4 years ago

@timabbott Can you have a look ?

akashaviator commented 4 years ago

@timabbott Can you have a look ?

timabbott commented 4 years ago

I don't think this latest change is an improvement over what we have in master; it introduces a potentially dangerous singleton object.

akashaviator commented 4 years ago

@timabbott Can you have a look ?

timabbott commented 4 years ago

Merged, thanks @akashaviator! Sequence is the right way to do this.