search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
353 stars 355 forks source link

Potential code quality issues found #607

Closed pnijhara closed 4 years ago

pnijhara commented 4 years ago

I have forked this repo and later to check code quality, I ran a DeepSource analysis on it. There I found around 700+ code quality issues, some of them can be easily fixed in a single click.

Those issues are categorized as:

Anti-pattern: 425 Bug Risk: 49 Performance: 188 Security: 57

Find a detailed report of the issues found here -> https://deepsource.io/gh/pnijhara/python-zulip-api/issues/?category=recommended

I have also added a deepsource config file to let DeepSource analyze my forked repo. The link of that file can be found here.

I want to send a patch with some fix.

Also do let me know which of the above issues you think are false positives and which of them are potential issues.

timabbott commented 4 years ago

We love taking patches that improve the codebase, and use other code scanners to look for them.

Based on past experience, I'd be surprised if many of those "700 issues" are real problems -- this class of tool is known for generating a lot of spam because it helps sell that class of software. And 188 "performance" issues in a small codebase like this API library is a sign that they're very aggressive about flagging things.