zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
359 stars 361 forks source link

Matrix bridge: Event object no longer has "membership" key. #612

Open rht opened 4 years ago

rht commented 4 years ago

The event object of this line only has these keys: ['unsigned', 'origin_server_ts', 'type', 'room_id', 'content', 'sender', 'event_id']. membership is gone.

timabbott commented 4 years ago

Is there any documentation for this change in the Matrix.org APIs?

rht commented 4 years ago

The example in https://github.com/matrix-org/matrix-python-sdk/blob/master/samples/SimpleChatClient.py still uses "membership" which no longer works. The Matrix API documentation doesn't have changelog that says any deprecation. Because of #604, the library used in the Matrix bridge is no longer actively maintained.

@timabbott is it worth it to modernize the Matrix bridge, or should I make the Zulip Go API work so that people can use Matterbridge?

timabbott commented 4 years ago

Can you open an issue with the Matrix.org folks for that membership bug? I think @Hypro999 might be interested in collaborating on fixing Matterbridge.

rht commented 3 years ago

This will be closed by #723 since it uses matrix-nio.