zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
353 stars 355 forks source link

[BUGFIX] IRC bridge: Use connection initialized from aio_reactor and document --nickserv-pw. #615

Closed rht closed 4 years ago

rht commented 4 years ago

Additionally, pin the irc library version to 18.0 because the newer version has an error in the AioReactor:

  File "/home/rht/code/venv/lib/python3.8/site-packages/irc/bot.py", line 108, in run
    self.bot.reactor.scheduler.execute_after(intvl, self.check)
AttributeError: 'AioReactor' object has no attribute 'scheduler'
lu-zero commented 4 years ago

I confirm it works :)

timabbott commented 4 years ago

Merged, thanks @rht and @lu-zero!