search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
359 stars 361 forks source link

Move away from virtualenv #625

Closed showell closed 3 years ago

showell commented 4 years ago

Since python3.5, the recommended methodology for creating virtual environments is to use the native venv module.

Now that we no longer support older versions of python, we no longer need virtualenv.

More discussion here: https://chat.zulip.org/#narrow/stream/2-general/topic/page.20not.20found/near/1022651

QEDK commented 4 years ago

I'll just add a note that while venv works fine on native Linux distributions, Microsoft's WSL and Windows itself work quite badly with it. I'm not quite sure why to be honest but venv itself is plagued with permissions errors (on WSL atleast). While it's surely something upstream, just my two cents.

LoopThrough-i-j commented 3 years ago

I hope this issue is open to work @showell. Can you please add some labels that would allow me to claim the issue.

LoopThrough-i-j commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Hello @LoopThrough-i-j!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

LoopThrough-i-j commented 3 years ago

I'll just add a note that while venv works fine on native Linux distributions, Microsoft's WSL and Windows itself work quite badly with it. I'm not quite sure why to be honest but venv itself is plagued with permissions errors (on WSL atleast). While it's surely something upstream, just my two cents.

@QEDK, @showell and @neiljp I tested venv on WSL and everything felt nice and smooth. Not sure of the issue @QEDK is talking about. I insatlled windows to test everything out. Probably @QEDK made some irregular sudo usage that could have broken venv(I am not sure though).

QEDK commented 3 years ago

I'll just add a note that while venv works fine on native Linux distributions, Microsoft's WSL and Windows itself work quite badly with it. I'm not quite sure why to be honest but venv itself is plagued with permissions errors (on WSL atleast). While it's surely something upstream, just my two cents.

@QEDK, @showell and @neiljp I tested venv on WSL and everything felt nice and smooth. Not sure of the issue @QEDK is talking about. I insatlled windows to test everything out. Probably @QEDK made some irregular sudo usage that could have broken venv(I am not sure though).

You missed what I said on Zulip, it needs to be the Windows filesystem inside WSL. I know to not use sudo, the way file systems are implemented are what's the problem, which even causes problems with Git.

LoopThrough-i-j commented 3 years ago

@QEDK yeah, I understand and am trying things out. I wrote this comment before checking for the chat, sorry for that. btw I tested out with the windows file system as well in different drives. We can continue our chat at chat.zulip.org.

QEDK commented 3 years ago

It's totally cool, I'm just explaining why it's an issue. I've replied on Zulip more thoroughly.

On Sat, 23 Jan, 2021, 18:11 Debayan Ganguly, notifications@github.com wrote:

@QEDK https://github.com/QEDK yeah, I understand and am trying things out. I wrote this comment before checking for the chat, sorry for that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zulip/python-zulip-api/issues/625#issuecomment-765969339, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWRQQT5YPLDV52OLTZ4ZDS3K7ZBANCNFSM4RW6WIUA .

zulipbot commented 3 years ago

Hello @LoopThrough-i-j, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

LoopThrough-i-j commented 3 years ago

@rht would you mind taking a look at the PR