zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

350 stars 356 forks source link

WIP: SSL on IRC connection #629

Open benjaoming opened 3 years ago

benjaoming commented 3 years ago

I thought this would be easy -- but so far, it has just been a rabbit hole of sorts.

So I'm posing my current results.

496

Issues:

[ ] Messages are not forwarded from Zulip=>IRC, the connection breaks and we get:

irc_mirror_zulip has left the room (Quit: Read error: error:1408F119:SSL routines:ssl3_get_record:decryption failed or bad record mac).
[x] No scheduler object, so reconnections aren't scheduled and the whole bridge dies

PIG208 commented 3 years ago

Hi @benjaoming, are you still interested in working this?

benjaoming commented 3 years ago

@PIG208 - I would be happy to comment/review on any work extending on this, but realistically I don't have time to finish it. I don't think there's anything in this PR that couldn't be taken further.

I'll try to ask around if anyone would be interested in picking it up.

zulipbot commented 3 years ago

Heads up @benjaoming, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

benjaoming commented 3 years ago

This PR is now updated with the conflicts caused by black linting.

zulipbot commented 1 month ago

Heads up @benjaoming, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.