Closed andersk closed 3 years ago
@andersk can I work on this?
@zulipbot claim
Hello @LoopThrough-i-j!
Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.
If this is your first time here, we recommend reading our guide for new contributors before getting started.
@zulipbot claim
Hello @ahmedabuamra, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.
We look forward to your valuable contributions!
@andersk Can I work on this issue as the in progress
one is in review?
@zulipbot claim
Hello @LoopThrough-i-j!
Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.
If this is your first time here, we recommend reading our guide for new contributors before getting started.
@zulipbot claim
Welcome to Zulip, @LoopThrough-i-j! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
zulip/zulip currently needs an unchecked cast to convert a custom
EmbeddedBotHandler
class into anExternalBotHandler
. SinceEmbeddedBotHandler
is not a subclass ofExternalBotHandler
(because it works by invokinginternal_send_message
rather than making API calls), this is unsafe, and it breaks in practice when we try to upgrade python-zulip-api to 0.7.1 (zulip/zulip#16511).To fix this, we need a common base class or Mypy protocol, say
BotHandler
, that can be subclassed by bothExternalBotHandler
andEmbeddedBotHandler
. Thezulip_bots
functions must be relaxed to acceptBotHandler
instead of requiringExternalBotHandler
.If the
StubBotHandler
class used in tests could subclassBotHandler
too, I think this would also let us correct variousbot_handler: Any
types tobot_handler: BotHandler
.