search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

Update game_handler.py #641

Closed vinitwadgaonkar closed 3 years ago

vinitwadgaonkar commented 3 years ago

tried changing !avatar tag to html

vinitwadgaonkar commented 3 years ago

this is for #632

vinitwadgaonkar commented 3 years ago

@neiljp sir please review

timabbott commented 3 years ago

Thanks for working on this! I don't understand these changes, and in particular I don't think they'll work -- you're trying to add HTML tags that aren't allowed in Zulip's markdown implementation.

I'll add that one of the most important things to do when contributing to an open source project (or software development in general) is writing commit messages that explain why your changes are correct.

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

vinitwadgaonkar commented 3 years ago

okay sir i will take care of this next time

On Wed, 27 Jan 2021 at 00:27, Tim Abbott notifications@github.com wrote:

Closed #641 https://github.com/zulip/python-zulip-api/pull/641.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zulip/python-zulip-api/pull/641#event-4252231794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVUUTO36BVSYATBTA4D5HDS34GAVANCNFSM4VSZQ5HA .

-- Vinit Wadgaonkar