Closed LoopThrough-i-j closed 3 years ago
@LoopThrough-i-j you haven't included the static analysis https://github.com/zulip/python-zulip-api/blob/master/.travis.yml#L9-L14.
Your commit messages should end with a fullstop ('.').
For other reviewers wanting to check the build: https://github.com/LoopThrough-i-j/python-zulip-api/actions.
@LoopThrough-i-j you haven't included the static analysis https://github.com/zulip/python-zulip-api/blob/master/.travis.yml#L9-L14.
Thanks a lot for your review, will add the static analysis
Your commit messages should end with a fullstop ('.').
I am sorry for this, probably the lint for git commit is not set.
Thanks for doing this, @LoopThrough-i-j! As I mentioned in the other PR, having confidence the the current state of the tests is really key, so not having it show up on PRs is really important to get fixed -- so thank you for tackling that. @rht's commented on more or less everything I can think of, so I don't have much to add. :)
@LoopThrough-i-j nit: your Dropbox commit message is more concise if you just say: 'dropbox_share: Pin version of dropbox
dependency.' and then in the secondary description of the commit message say that the version after 10.10.0 fails the test.
@LoopThrough-i-j you should add a commit to remove .travis.yml at the end.
You forgot to react to this.
@LoopThrough-i-j you should add a commit to remove .travis.yml at the end.
You forgot to react to this.
@rht I didn't remove the .travis.yml to keep it for reference. I will remove it from my final commit once everyone is fine with it.
Typo in the Dropbox commit message: "verion".
Also, you must use imperative statement, not "fixed". I think it is more relevant to say "Pin" than "Fix".
You forgot full stop for the first commit again.
You forgot full stop for the first commit again.
Yeah, I added it now. I think we don't have git lint set here. Can I work on that next? @rht
Another nit: in the commit message "pin" and "setup" should be capitalized. E.g. see https://github.com/zulip/zulip/commit/42dfd9860702ed4dc450023fbf22e7bbd88ae8de.
Another nit: in the commit message "pin" and "setup" should be capitalized. E.g. see zulip/zulip@42dfd98.
@rht This is updated I hope everything looks good now. We can probably resolve the unresolved issue above and Keep the Jobs separate for separate reports.
I think we don't have git lint set here. Can I work on that next?
Sounds good. This is the issue on zulip/zulip, and this the commit that closed it.
Yes, I will create a new PR for Git Lint Setup.
@LoopThrough-i-j I don't see CI as having run on this PR -- any idea why?
@timabbott because it runs on push to master
on:
push:
branches:
- master
and for all pull requests
pull_request:
The branch I committed to in my fork is not master but named CI. I have tested it out thoroughly to make it work, and have got all the issues fixed.
Merged the first commit, after copying the commit message into a comment, as e995e52896a9fa93678eedb777d6d63927913bb5.
Can you post a link to the CI run output with GitHub Actions?
Merged the first commit, after copying the commit message into a comment, as e995e52.
Can you post a link to the CI run output with GitHub Actions?
This Actionswon't run till it is merged in the original repository. Because the Repo does not have the required build files to run it. I can run it on my fork by removing master from it.
branches:
- master
Hopefull I could explain it to you.
@timabbott zulip/zulip has on [push, pull_request]
in almost all workflows (except production). There is discussion above on this alternative, but I'd be interested to hear what you think since the choice in this PR is different to zulip/zulip.
I can run it on my fork by removing master from it.
@LoopThrough-i-j alternatively you can make a PR to the master branch in your repo, so you don't have to modify any code.
FTR @andersk restricted the push to only master (https://github.com/zulip/zulip-desktop/commit/a1bb6da4fb3ffd2007b147c184f64300711094f4) at zulip/zulip-desktop.
@timabbott here is a sample build I triggered to test if everything still works, for clarity.
Thank you for being persistent on this, and apologies for the delay. I've reformatted the yml with prettier and merged.
Thank you for being persistent on this, and apologies for the delay. I've reformatted the yml with prettier and merged.
No problem thanks.
@LoopThrough-i-j you should add a commit to remove .travis.yml at the end.