search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

Setup Gitlint. #645

Closed LoopThrough-i-j closed 3 years ago

LoopThrough-i-j commented 3 years ago

@alexmv The changes are made. I think they look good to be merged now, still consider reviewing and add any more suggestions if required.

timabbott commented 3 years ago

For the files copied from zulip/zulip, can you add a comment noting that's the case at the top of the file? And also mention if anything has changed. Something like:

# This file is copied from the original at tools/foobar in zulip/zulip.
# Please don't edit here; instead update the zulip/zulip copy and then resync this file.
timabbott commented 3 years ago

Resolved the minor merge conflict when rebasing and merged, thanks @LoopThrough-i-j!

One thing I noticed is that mypy prints a bunch of debug output that it doesn't on zulip/zulip; can you look into whatever flag we need to suppress that?

mypy      | Running mypy for `zulip`.
mypy      | Success: no issues found in 69 source files
mypy      | Running mypy for `zulip_bots`.
mypy      | Success: no issues found in 75 source files
mypy      | Running mypy for `zulip_botserver`.
mypy      | Success: no issues found in 7 source files
mypy      | Running mypy for `tools`.
mypy      | Success: no issues found in 2 source files
LoopThrough-i-j commented 3 years ago

Sure will check and push a fix. Thanks for the merge.