search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

Provide a mechanism for passing `all_public_streams` to `call_on_each_*` #647

Closed timabbott closed 3 years ago

timabbott commented 3 years ago

I suppose the specific flag isn't important -- I named an undocumented one in the title, but call_on_each_* need to support passing additional parameters to /register, and currently seem not to. Probably simplest is to just support an additional parameters dictionary? But mainly, we should try to be consistent with existing functions.

Once we add the feature, we should remember to update zulip/zulip to document it.

LoopThrough-i-j commented 3 years ago

@timabbott I wanted to work on this issue, but I have some PRs waiting to be reviewed. Can I work on this?

LoopThrough-i-j commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Hello @LoopThrough-i-j!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

LoopThrough-i-j commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Hello @LoopThrough-i-j!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

LoopThrough-i-j commented 3 years ago

So, the documentation for this is left I hope.

timabbott commented 3 years ago

Agree, and I think that's a PR for zulip/zulip, since that's where the documentation for call_on_each_* lives. I think a Fixes: zulip/python-zulip-api#647 in the zulip/zulip commit would allow it to close this issue when merged.