Added remove_storage helper to the Python API.

zulip / python-zulip-api

Python library for the Zulip API.

https://zulip.com/api/

Apache License 2.0

350 stars 356 forks source link

Added remove_storage helper to the Python API. #648

Closed RioAtHome closed 3 years ago

RioAtHome commented 3 years ago

A pr for issue #637. Added remove_storage for the zulip API, and storage.remove for the bot framework, I'm not sure if I did the tests the right way, need some feedback on it.

i intend to add storage.remove to the bot framework documentation if this pr is good.

showell commented 3 years ago

LGTM.

timabbott commented 3 years ago

@R0cker77 can you clean up the commit history for this PR?

Check out our GitHub guide and commit guidelines for more details.

timabbott commented 3 years ago

Thanks for working on this @R0cker77! A few notes:

I'd prefix the commit with zulip:, since that's the relevant subpackage.
Generally you need to post a comment in GitHub when you've resolved the last comments -- otherwise maintainers won't know to look at your PR again.

RioAtHome commented 3 years ago

@timabbott Thank you for the feedback. I added zulip : , prefix to commit, and changed the example to the correct form. I’m eager to receive your feedback.