Open ahmedabuamra opened 3 years ago
@andersk thank you for your comments! I agree with all of them and will update you once resolved.
This looks pretty good; I merged the first commit as 9ce2ea53a50cf80554c9014ebfa500a8f211b529 (after updating the commit message to say Fixes part of #632
-- the way you had it would close the issue as soon as the first commit is merged, even if the second wasn't ready yet.
@ahmedabuamra have you had a chance to resolve the feedback on this?
@timabbott I am sorry for not working on it till now. I have had exams from the beginning of this month to yesterday. I will resolve it as soon as possible. Thank you.
Heads up @ahmedabuamra, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main
branch and resolve your pull request's merge conflicts accordingly.
Fixes: #632
Message content example (on my forked repo.):![image](https://user-images.githubusercontent.com/30929038/106991360-b8dd8e80-677e-11eb-8094-9712fe563a1e.png)
Please note this sample is generated with input:
5f81eb3a7071fa0dfc20335d01ad889edca27f4e e995e52896a9fa93678eedb777d6d63927913bb5 refs/heads/master
which formatting output of:
git log --reverse --pretty=%aN%n%H%n%h%n%s 5f81eb3a7071fa0dfc20335d01ad889edca27f4e..e995e52896a9fa93678eedb777d6d63927913bb5