zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

Make tests work on Windows #651

Closed gnprice closed 3 years ago

gnprice commented 3 years ago

We've had a report in chat that the tests don't pass on Windows. Two tests fail, either because they're assuming / is the path-separator character or because of a case mismatch that looks like they're assuming the filesystem is case-sensitive.

Python itself works perfectly fine on Windows, so we should have our Python bindings work fine on Windows too, and we should have our tests pass on Windows to reflect that. I'm not sure if the bug here is only in the tests, or if it affects the library itself, but either way it should be fixed.

ganpa3 commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Welcome to Zulip, @ganpa3! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!