search

zulip / python-zulip-api

Python library for the Zulip API.
https://zulip.com/api/
Apache License 2.0
350 stars 356 forks source link

zulip: Update `reaction_data` type. #653

Closed LoopThrough-i-j closed 3 years ago

LoopThrough-i-j commented 3 years ago

Update reaction_data type in add_reaction and remove_reaction, from Dict[str, str] to Dict[str, Any]

amanagr commented 3 years ago

For both the PRs, you don't need to write the whole file name in the commit message. See https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Something like reactions_api would be more appropriate.

LoopThrough-i-j commented 3 years ago

Actually, I saw Anders Kaseorg doing this for single file changes, hence thought that could be a better practice for a single file commit.

rht commented 3 years ago

Posting the relevant discussion thread for future reference: https://chat.zulip.org/#narrow/stream/127-integrations/topic/msg.20id.20in.20add_emoji.20doc.

timabbott commented 3 years ago

Merged, thanks @LoopThrough-i-j!