Closed LoopThrough-i-j closed 3 years ago
For both the PRs, you don't need to write the whole file name in the commit message. See https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
Something like reactions_api
would be more appropriate.
Actually, I saw Anders Kaseorg doing this for single file changes, hence thought that could be a better practice for a single file commit.
Posting the relevant discussion thread for future reference: https://chat.zulip.org/#narrow/stream/127-integrations/topic/msg.20id.20in.20add_emoji.20doc.
Merged, thanks @LoopThrough-i-j!
Update
reaction_data
type in add_reaction and remove_reaction, from Dict[str, str] to Dict[str, Any]